Pin torchvision, torch, and torchaudio versions#13757
Open
sayakpaul wants to merge 4 commits into
Open
Conversation
Collaborator
|
I think we tend to pin/unpin frequently enough that we can add build args to the env section in In the build images workflow env:
REGISTRY: diffusers
CI_SLACK_CHANNEL: ${{ secrets.CI_DOCKER_CHANNEL }}
TORCH_VERSION: 2.10.0 # set to "" to use latest Update the build instructions with:
no-cache: true
context: ./docker/${{ matrix.image-name }}
push: true
tags: ${{ env.REGISTRY }}/${{ matrix.image-name }}:latest
build-args: |
TORCH_VERSION=${{ env.TORCH_VERSION }}
Inside the Dockerfile, we would need RUN uv pip install --no-cache-dir \
"torch${TORCH_VERSION:+==${TORCH_VERSION}}" \
torchvision \
torchaudio \
--extra-index-url https://download.pytorch.org/whl/cpu |
Member
Author
But when we do RUN uv pip install --no-cache-dir \
torch \
torchvision \
torchaudio somehow the resolution isn't appropriate.
This feels inappropriate for non-CPU envs i.e., for the GPU docker containers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Facing torchvision problems because of unpinned versions:
https://github.com/huggingface/diffusers/actions/runs/25903410768/job/76131726872?pr=13733
This PR should fix it.
Pushed the Docker containers too: https://github.com/huggingface/diffusers/actions/runs/25907563120.
Tested with the container and verified that it's working as expected.